Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Delete unused SentryBeforeEmitMetricCallback #4516

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Nov 7, 2024

We missed this bit in #4406.

This is based on #4515.

#skip-changelog

Copy link

github-actions bot commented Nov 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.84 ms 1237.90 ms 26.06 ms
Size 21.90 KiB 727.71 KiB 705.81 KiB

Baseline results on branch: chore/format-code

Startup times

Revision Plain With Sentry Diff
292e0d3 1210.44 ms 1248.30 ms 37.87 ms

App size

Revision Plain With Sentry Diff
292e0d3 21.58 KiB 713.54 KiB 691.96 KiB

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.469%. Comparing base (84640bd) to head (b8b98d7).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4516       +/-   ##
=============================================
- Coverage   91.472%   91.469%   -0.003%     
=============================================
  Files          615       615               
  Lines        68985     68989        +4     
  Branches     24739     24746        +7     
=============================================
+ Hits         63102     63104        +2     
- Misses        5791      5792        +1     
- Partials        92        93        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m 86.432% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84640bd...b8b98d7. Read the comment docs.

Base automatically changed from chore/format-code to main November 7, 2024 14:40
@philipphofmann philipphofmann merged commit 9854a57 into main Nov 7, 2024
64 of 65 checks passed
@philipphofmann philipphofmann deleted the ref/delete-unused-metrics-callback branch November 7, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants